Commit d33d0eb2 authored by James Smart's avatar James Smart Committed by Martin K. Petersen
Browse files

scsi: lpfc: Driver fails to detect direct attach storage array 



The driver does not respond to PLOGI from the direct attach target.  The
driver uses incorrect S_ID in CONFIG_LINK, after FLOGI completion

Correct by issuing CONFIG_LINK with the correct S_ID after receiving the
PLOGI from the target

Signed-off-by: default avatarDick Kennedy <dick.kennedy@broadcom.com>
Signed-off-by: default avatarJames Smart <james.smart@broadcom.com>
Reviewed-by: default avatarHannes Reinecke <hare@suse.com>
Signed-off-by: default avatarMartin K. Petersen <martin.petersen@oracle.com>
parent d73154ba

drivers/scsi/lpfc/lpfc_els.c

+20 −16
Original line number Diff line number Diff line
@@ -858,6 +858,9 @@ lpfc_cmpl_els_flogi_nport(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, 
	vport->fc_flag |= FC_PT2PT;

	spin_unlock_irq(shost->host_lock);



	/* If we are pt2pt with another NPort, force NPIV off! */

	phba->sli3_options &= ~LPFC_SLI3_NPIV_ENABLED;



	/* If physical FC port changed, unreg VFI and ALL VPIs / RPIs */

	if ((phba->sli_rev == LPFC_SLI_REV4) && phba->fc_topology_changed) {

		lpfc_unregister_fcf_prep(phba);
@@ -916,15 +919,6 @@ lpfc_cmpl_els_flogi_nport(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, 
		spin_lock_irq(shost->host_lock);

		ndlp->nlp_flag |= NLP_NPR_2B_DISC;

		spin_unlock_irq(shost->host_lock);

	} else

		/* This side will wait for the PLOGI, decrement ndlp reference

		 * count indicating that ndlp can be released when other

		 * references to it are done.

		 */

		lpfc_nlp_put(ndlp);



	/* If we are pt2pt with another NPort, force NPIV off! */

	phba->sli3_options &= ~LPFC_SLI3_NPIV_ENABLED;



		mbox = mempool_alloc(phba->mbox_mem_pool, GFP_KERNEL);

		if (!mbox)
@@ -939,6 +933,16 @@ lpfc_cmpl_els_flogi_nport(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, 
			mempool_free(mbox, phba->mbox_mem_pool);

			goto fail;

		}

	} else {

		/* This side will wait for the PLOGI, decrement ndlp reference

		 * count indicating that ndlp can be released when other

		 * references to it are done.

		 */

		lpfc_nlp_put(ndlp);



		/* Start discovery - this should just do CLEAR_LA */

		lpfc_disc_start(vport);

	}



	return 0;

fail:

CRA Git | Maintained and supported by SUSTech CRA and CCSE