Commit d33b58d0 authored by Daniel Vetter's avatar Daniel Vetter
Browse files

drm: Garbage collect drm_dev_fini 



It has become empty. Given the few users I figured not much point
splitting this up.

v2: Rebase over i915 changes.

v3: Rebase over patch split fix.

Acked-by: default avatarSam Ravnborg <sam@ravnborg.org>
Signed-off-by: default avatarDaniel Vetter <daniel.vetter@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200323144950.3018436-26-daniel.vetter@ffwll.ch
parent c23d686f

drivers/gpu/drm/cirrus/cirrus.c

+0 −1
Original line number Diff line number Diff line
@@ -529,7 +529,6 @@ static void cirrus_mode_config_init(struct cirrus_device *cirrus) 
static void cirrus_release(struct drm_device *dev)

{

	drm_mode_config_cleanup(dev);

	drm_dev_fini(dev);

}



DEFINE_DRM_GEM_FOPS(cirrus_fops);

drivers/gpu/drm/drm_drv.c

+0 −20
Original line number Diff line number Diff line
@@ -282,7 +282,6 @@ void drm_minor_release(struct drm_minor *minor) 
 *		struct driver_device *priv = container_of(...);

 *

 *		drm_mode_config_cleanup(drm);

 *		drm_dev_fini(drm);

 *	}

 *

 *	static struct drm_driver driver_drm_driver = {
@@ -737,23 +736,6 @@ int devm_drm_dev_init(struct device *parent, 
}

EXPORT_SYMBOL(devm_drm_dev_init);



/**

 * drm_dev_fini - Finalize a dead DRM device

 * @dev: DRM device

 *

 * Finalize a dead DRM device. This is the converse to drm_dev_init() and

 * frees up all data allocated by it. All driver private data should be

 * finalized first. Note that this function does not free the @dev, that is

 * left to the caller.

 *

 * The ref-count of @dev must be zero, and drm_dev_fini() should only be called

 * from a &drm_driver.release callback.

 */

void drm_dev_fini(struct drm_device *dev)

{

}

EXPORT_SYMBOL(drm_dev_fini);



/**

 * drm_dev_alloc - Allocate new DRM device

 * @driver: DRM driver to allocate device for
@@ -804,8 +786,6 @@ static void drm_dev_release(struct kref *ref) 


	if (dev->driver->release)

		dev->driver->release(dev);

	else

		drm_dev_fini(dev);



	drm_managed_release(dev);

drivers/gpu/drm/drm_mipi_dbi.c

+0 −1
Original line number Diff line number Diff line
@@ -592,7 +592,6 @@ void mipi_dbi_release(struct drm_device *drm) 
	DRM_DEBUG_DRIVER("\n");



	drm_mode_config_cleanup(drm);

	drm_dev_fini(drm);

}

EXPORT_SYMBOL(mipi_dbi_release);

drivers/gpu/drm/i915/i915_drv.c

+0 −7
Original line number Diff line number Diff line
@@ -906,11 +906,6 @@ i915_driver_create(struct pci_dev *pdev, const struct pci_device_id *ent) 
	return i915;

}



static void i915_driver_destroy(struct drm_i915_private *i915)

{

	drm_dev_fini(&i915->drm);

}



/**

 * i915_driver_probe - setup chip and create an initial config

 * @pdev: PCI device
@@ -1013,7 +1008,6 @@ out_pci_disable: 
	pci_disable_device(pdev);

out_fini:

	i915_probe_error(i915, "Device initialization failed (%d)\n", ret);

	i915_driver_destroy(i915);

	drm_dev_put(&i915->drm);

	return ret;

}
@@ -1070,7 +1064,6 @@ static void i915_driver_release(struct drm_device *dev) 
	intel_runtime_pm_driver_release(rpm);



	i915_driver_late_release(dev_priv);

	i915_driver_destroy(dev_priv);

}



static int i915_driver_open(struct drm_device *dev, struct drm_file *file)

drivers/gpu/drm/i915/selftests/mock_gem_device.c

+0 −2
Original line number Diff line number Diff line
@@ -76,7 +76,6 @@ static void mock_device_release(struct drm_device *dev) 


	drm_mode_config_cleanup(&i915->drm);



	drm_dev_fini(&i915->drm);

out:

	put_device(&i915->drm.pdev->dev);

	i915->drm.pdev = NULL;
@@ -215,7 +214,6 @@ err_drv: 
	intel_gt_driver_late_release(&i915->gt);

	intel_memory_regions_driver_release(i915);

	drm_mode_config_cleanup(&i915->drm);

	drm_dev_fini(&i915->drm);

	drm_dev_put(&i915->drm);



	return NULL;

CRA Git | Maintained and supported by SUSTech CRA and CCSE