Commit d339727c authored Jul 06, 2015 by Eric Dumazet Committed by David S. Miller Jul 08, 2015

net: graceful exit from netif_alloc_netdev_queues()



User space can crash kernel with

ip link add ifb10 numtxqueues 100000 type ifb

We must replace a BUG_ON() by proper test and return -EINVAL for
crazy values.

Fixes: 60877a32 ("net: allow large number of tx queues")
Signed-off-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 142b942a

net/core/dev.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -6409,7 +6409,8 @@ static int netif_alloc_netdev_queues(struct net_device *dev)
		struct netdev_queue *tx;
		size_t sz = count * sizeof(*tx);

		BUG_ON(count < 1 \|\| count > 0xffff);
		if (count < 1 \|\| count > 0xffff)
		return -EINVAL;

		tx = kzalloc(sz, GFP_KERNEL \| __GFP_NOWARN \| __GFP_REPEAT);
		if (!tx) {

Admin message