Commit d310d05f authored Aug 01, 2014 by Oliver Neukum Committed by Greg Kroah-Hartman Aug 01, 2014

USB: devio: fix issue with log flooding

usbfs allows user space to pass down an URB which sets URB_SHORT_NOT_OK
for output URBs. That causes usbcore to log messages without limit
for a nonsensical disallowed combination. The fix is to silently drop
the attribute in usbfs.
The problem is reported to exist since 3.14
https://www.virtualbox.org/ticket/13085



Signed-off-by: Oliver Neukum <oneukum@suse.de>
CC: stable@vger.kernel.org
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 43508be5

drivers/usb/core/devio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1509,7 +1509,7 @@ static int proc_do_submiturb(struct usb_dev_state ps, struct usbdevfs_urb uurb
		u = (is_in ? URB_DIR_IN : URB_DIR_OUT);
		if (uurb->flags & USBDEVFS_URB_ISO_ASAP)
		u \|= URB_ISO_ASAP;
		if (uurb->flags & USBDEVFS_URB_SHORT_NOT_OK)
		if (uurb->flags & USBDEVFS_URB_SHORT_NOT_OK && is_in)
		u \|= URB_SHORT_NOT_OK;
		if (uurb->flags & USBDEVFS_URB_NO_FSBR)
		u \|= URB_NO_FSBR;

Admin message