Commit d2f112a5 authored by Christoph Niedermaier's avatar Christoph Niedermaier Committed by Jonathan Corbet
Browse files

Docs/EDID: Fixed erroneous bits of XOFFSET, XPULSE, YOFFSET and YPULSE 



The problem was found when EDID data sets for displays other
than the provided samples were generated. The patch has
no effect on the provided samples that still match the data
used in drivers/gpu/drm/drm_edid_load.c.

The provided samples use small values for XOFFSET, XPULSE,
YOFFSET and YPULSE, where the error doesn't occur. This fix
corrects the use of that values in case of high values, because
the most significant bits were treated incorrectly.

So in edid.S msbs4 should use bit 8 and 9 of XOFFSET and XPULS.
For YOFFSET and YPULSE msbs4 should use bit 4 and 5.

lsbs2 was introduced for a better overview, without
functional change.

Removing also the useless value 63 of all files, because
it is added in the *.S description files and then it is
subtracted in edid.S.

Signed-off-by: default avatarChristoph Niedermaier <cniedermaier@dh-electronics.de>
Reviewed-by: default avatarCarsten Emde <C.Emde@osadl.org>
Signed-off-by: default avatarJonathan Corbet <corbet@lwn.net>
parent 65102238

Documentation/EDID/1024x768.S

+2 −2
Original line number Diff line number Diff line
@@ -31,8 +31,8 @@ 
#define YBLANK 38

#define XOFFSET 8

#define XPULSE 144

#define YOFFSET (63+3)

#define YPULSE (63+6)

#define YOFFSET 3

#define YPULSE 6

#define DPI 72

#define VFREQ 60 /* Hz */

#define TIMING_NAME "Linux XGA"

Documentation/EDID/1280x1024.S

+2 −2
Original line number Diff line number Diff line
@@ -31,8 +31,8 @@ 
#define YBLANK 42

#define XOFFSET 48

#define XPULSE 112

#define YOFFSET (63+1)

#define YPULSE (63+3)

#define YOFFSET 1

#define YPULSE 3

#define DPI 72

#define VFREQ 60 /* Hz */

#define TIMING_NAME "Linux SXGA"

Documentation/EDID/1600x1200.S

+2 −2
Original line number Diff line number Diff line
@@ -31,8 +31,8 @@ 
#define YBLANK 50

#define XOFFSET 64

#define XPULSE 192

#define YOFFSET (63+1)

#define YPULSE (63+3)

#define YOFFSET 1

#define YPULSE 3

#define DPI 72

#define VFREQ 60 /* Hz */

#define TIMING_NAME "Linux UXGA"

Documentation/EDID/1680x1050.S

+2 −2
Original line number Diff line number Diff line
@@ -31,8 +31,8 @@ 
#define YBLANK 39

#define XOFFSET 104

#define XPULSE 176

#define YOFFSET (63+3)

#define YPULSE (63+6)

#define YOFFSET 3

#define YPULSE 6

#define DPI 96

#define VFREQ 60 /* Hz */

#define TIMING_NAME "Linux WSXGA"

Documentation/EDID/1920x1080.S

+2 −2
Original line number Diff line number Diff line
@@ -31,8 +31,8 @@ 
#define YBLANK 45

#define XOFFSET 88

#define XPULSE 44

#define YOFFSET (63+4)

#define YPULSE (63+5)

#define YOFFSET 4

#define YPULSE 5

#define DPI 96

#define VFREQ 60 /* Hz */

#define TIMING_NAME "Linux FHD"

CRA Git | Maintained and supported by SUSTech CRA and CCSE