checkpatch: suggest cleanpatch and cleanfile when appropriate (d2c0a235) · Commits · 戴 / test

scripts/checkpatch.pl

+13 −0

Original line number	Diff line number	Diff line
		@@ -103,6 +103,8 @@ for my $key (keys %debug) {
		die "$@" if ($@);
		}

		my $rpt_cleaners = 0;

		if ($terse) {
		$emacs = 1;
		$quiet++;
		@@ -1389,6 +1391,7 @@ sub process {
		} elsif ($rawline =~ /^\+.*\S\s+$/ \|\| $rawline =~ /^\+\s+$/) {
		my $herevet = "$here\n" . cat_vet($rawline) . "\n";
		ERROR("trailing whitespace\n" . $herevet);
		$rpt_cleaners = 1;
		}

		# check for Kconfig help text having a real description
		@@ -1450,6 +1453,7 @@ sub process {
		$rawline =~ /^\+\s* \s*/) {
		my $herevet = "$here\n" . cat_vet($rawline) . "\n";
		ERROR("code indent should use tabs where possible\n" . $herevet);
		$rpt_cleaners = 1;
		}

		# check for space before tabs.
		@@ -2842,6 +2846,15 @@ sub process {
		print "\n" if ($quiet == 0);
		}

		if ($quiet == 0) {
		# If there were whitespace errors which cleanpatch can fix
		# then suggest that.
		if ($rpt_cleaners) {
		print "NOTE: whitespace errors detected, you may wish to use scripts/cleanpatch or\n";
		print " scripts/cleanfile\n\n";
		}
		}

		if ($clean == 1 && $quiet == 0) {
		print "$vname has no obvious style problems and is ready for submission.\n"
		}