Commit d2bdc492 authored by Michał Mirosław's avatar Michał Mirosław Committed by Greg Kroah-Hartman
Browse files

staging: wfx: use more power-efficient sleep for reset 



Replace udelay() with usleep_range() as all uses are in a sleepable context.

Signed-off-by: default avatarMichał Mirosław <mirq-linux@rere.qmqm.pl>
Link: https://lore.kernel.org/r/59e1e4e5bd80c1879ef36eaa59916e47005dbb04.1581416843.git.mirq-linux@rere.qmqm.pl


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 40a97d55

drivers/staging/wfx/bh.c

+1 −1
Original line number Diff line number Diff line
@@ -26,7 +26,7 @@ static void device_wakeup(struct wfx_dev *wdev) 
	gpiod_set_value_cansleep(wdev->pdata.gpio_wakeup, 1);

	if (wfx_api_older_than(wdev, 1, 4)) {

		if (!completion_done(&wdev->hif.ctrl_ready))

			udelay(2000);

			usleep_range(2000, 2500);

	} else {

		// completion.h does not provide any function to wait

		// completion without consume it (a kind of

drivers/staging/wfx/bus_spi.c

+2 −2
Original line number Diff line number Diff line
@@ -211,9 +211,9 @@ static int wfx_spi_probe(struct spi_device *func) 
		if (spi_get_device_id(func)->driver_data & WFX_RESET_INVERTED)

			gpiod_toggle_active_low(bus->gpio_reset);

		gpiod_set_value_cansleep(bus->gpio_reset, 1);

		udelay(100);

		usleep_range(100, 150);

		gpiod_set_value_cansleep(bus->gpio_reset, 0);

		udelay(2000);

		usleep_range(2000, 2500);

	}



	INIT_WORK(&bus->request_rx, wfx_spi_request_rx);

drivers/staging/wfx/hwio.c

+1 −1
Original line number Diff line number Diff line
@@ -142,7 +142,7 @@ static int indirect_read(struct wfx_dev *wdev, int reg, u32 addr, void *buf, 
			goto err;

		if (!(cfg & prefetch))

			break;

		udelay(200);

		usleep_range(200, 250);

	}

	if (i == 20) {

		ret = -ETIMEDOUT;

CRA Git | Maintained and supported by SUSTech CRA and CCSE