Commit d2b0c735 authored by Amitkumar Karwar's avatar Amitkumar Karwar Committed by Kalle Valo
Browse files

mwifiex: handle start AP error paths correctly 



It's been observed that even if firmware returns an error
for a configuration command, we go ahead and start AP.

This patch changes the command type from async to sync
so that threads waits for command response and return
failure start AP.

Signed-off-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarCathy Luo <cluo@marvell.com>
Signed-off-by: default avatarKalle Valo <kvalo@codeaurora.org>
parent d5556e87

drivers/net/wireless/marvell/mwifiex/ie.c

+1 −1
Original line number Diff line number Diff line
@@ -140,7 +140,7 @@ mwifiex_update_autoindex_ies(struct mwifiex_private *priv, 
	if (GET_BSS_ROLE(priv) == MWIFIEX_BSS_ROLE_UAP)

		return mwifiex_send_cmd(priv, HostCmd_CMD_UAP_SYS_CONFIG,

					HostCmd_ACT_GEN_SET,

					UAP_CUSTOM_IE_I, ie_list, false);

					UAP_CUSTOM_IE_I, ie_list, true);



	return 0;

}

drivers/net/wireless/marvell/mwifiex/uap_cmd.c

+3 −3
Original line number Diff line number Diff line
@@ -848,9 +848,9 @@ int mwifiex_config_start_uap(struct mwifiex_private *priv, 


	if (mwifiex_send_cmd(priv, HostCmd_CMD_UAP_SYS_CONFIG,

			     HostCmd_ACT_GEN_SET,

			     UAP_BSS_PARAMS_I, bss_cfg, false)) {

			     UAP_BSS_PARAMS_I, bss_cfg, true)) {

		mwifiex_dbg(priv->adapter, ERROR,

			    "Failed to set the SSID\n");

			    "Failed to set AP configuration\n");

		return -1;

	}
@@ -865,7 +865,7 @@ int mwifiex_config_start_uap(struct mwifiex_private *priv, 
	}



	if (mwifiex_send_cmd(priv, HostCmd_CMD_UAP_BSS_START,

			     HostCmd_ACT_GEN_SET, 0, NULL, false)) {

			     HostCmd_ACT_GEN_SET, 0, NULL, true)) {

		mwifiex_dbg(priv->adapter, ERROR,

			    "Failed to start the BSS\n");

		return -1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE