perf test: Check counts on all cpus in test__open_syscall_event_on_all_cpus (d2af9687) · Commits · 戴 / test

We were bailing out after the first count mismatch, do it in all to see if only some CPUs are not getting the expected number of events. Cc: Frederic Weisbecker <fweisbec@gmail.com> Cc: Ingo Molnar <mingo@elte.hu> Cc: Mike Galbraith <efault@gmx.de> Cc: Paul Mackerras <paulus@samba.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Stephane Eranian <eranian@google.com> Cc: Tom Zanussi <tzanussi@gmail.com> LKML-Reference: <new-submission> Signed-off-by:

Arnaldo Carvalho de Melo <acme@redhat.com>

tools/perf/builtin-test.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -408,6 +408,8 @@ static int test__open_syscall_event_on_all_cpus(void)
		goto out_close_fd;
		}

		err = 0;

		for (cpu = 0; cpu < cpus->nr; ++cpu) {
		unsigned int expected;

		@@ -416,18 +418,18 @@ static int test__open_syscall_event_on_all_cpus(void)

		if (perf_evsel__read_on_cpu(evsel, cpu, 0) < 0) {
		pr_debug("perf_evsel__open_read_on_cpu\n");
		goto out_close_fd;
		err = -1;
		break;
		}

		expected = nr_open_calls + cpu;
		if (evsel->counts->cpu[cpu].val != expected) {
		pr_debug("perf_evsel__read_on_cpu: expected to intercept %d calls on cpu %d, got %" PRIu64 "\n",
		expected, cpus->map[cpu], evsel->counts->cpu[cpu].val);
		goto out_close_fd;
		err = -1;
		}
		}

		err = 0;
		out_close_fd:
		perf_evsel__close_fd(evsel, 1, threads->nr);
		out_evsel_delete:

Admin message