Commit d29e0b26 authored May 28, 2020 by Paul E. McKenney

lockdep: Complain only once about RCU in extended quiescent state

Currently, lockdep_rcu_suspicious() complains twice about RCU read-side
critical sections being invoked from within extended quiescent states,
for example:

	RCU used illegally from idle CPU!
	rcu_scheduler_active = 2, debug_locks = 1
	RCU used illegally from extended quiescent state!

This commit therefore saves a couple lines of code and one line of
console-log output by eliminating the first of these two complaints.

Link: https://lore.kernel.org/lkml/87wo4wnpzb.fsf@nanos.tec.linutronix.de


Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Will Deacon <will@kernel.org>
Signed-off-by: Paul E. McKenney <paulmck@kernel.org>

parent 04b25a49

kernel/locking/lockdep.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -5851,8 +5851,6 @@ void lockdep_rcu_suspicious(const char file, const int line, const char s)
		pr_warn("\n%srcu_scheduler_active = %d, debug_locks = %d\n",
		!rcu_lockdep_current_cpu_online()
		? "RCU used illegally from offline CPU!\n"
		: !rcu_is_watching()
		? "RCU used illegally from idle CPU!\n"
		: "",
		rcu_scheduler_active, debug_locks);

Admin message