Commit d2886ea3 authored May 11, 2008 by Stefan Richter

scsi: sd: optionally set power condition in START STOP UNIT

Adds a new scsi_device flag, start_stop_pwr_cond:  If enabled, the sd
driver will not send plain START STOP UNIT commands but ones with the
power condition field set to 3 (standby) or 1 (active) respectively.

Some FireWire disk firmwares do not stop the motor if power condition is
zero.  Or worse, they become unresponsive after a START STOP UNIT with
power condition = 0 and start = 0.

http://lkml.org/lkml/2008/4/29/704



This patch only adds the necessary code to sd_mod but doesn't activate
it.  Follow-up patches to the FireWire drivers will add detection of
affected devices and enable the code for them.

I did not add power condition values to scsi_error.c::scsi_eh_try_stu()
for now.  The three firmwares which suffer from above mentioned problems
do not need START STOP UNIT in the error handler, and they are not
adversely affected by START STOP UNIT with power condition = 0 and start
= 1 (like scsi_eh_try_stu() sends it if scsi_device.allow_restart is
enabled).

Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
Tested-by: Tino Keitel <tino.keitel@gmx.de>

parent bce7f793

drivers/scsi/sd.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -1124,6 +1124,8 @@ sd_spinup_disk(struct scsi_disk *sdkp)
		cmd[1] = 1; /* Return immediately */
		memset((void *) &cmd[2], 0, 8);
		cmd[4] = 1; /* Start spin cycle */
		if (sdkp->device->start_stop_pwr_cond)
		cmd[4] \|= 1 << 4;
		scsi_execute_req(sdkp->device, cmd, DMA_NONE,
		NULL, 0, &sshdr,
		SD_TIMEOUT, SD_MAX_RETRIES);
		@@ -1790,6 +1792,9 @@ static int sd_start_stop_device(struct scsi_disk *sdkp, int start)
		if (start)
		cmd[4] \|= 1; /* START */

		if (sdp->start_stop_pwr_cond)
		cmd[4] \|= start ? 1 << 4 : 3 << 4; /* Active or Standby */

		if (!scsi_device_online(sdp))
		return -ENODEV;

include/scsi/scsi_device.h

+1 −0

Original line number	Diff line number	Diff line
		@@ -134,6 +134,7 @@ struct scsi_device {
		unsigned no_start_on_add:1; /* do not issue start on add */
		unsigned allow_restart:1; /* issue START_UNIT in error handler */
		unsigned manage_start_stop:1; /* Let HLD (sd) manage start/stop */
		unsigned start_stop_pwr_cond:1; /* Set power cond. in START_STOP_UNIT */
		unsigned no_uld_attach:1; /* disable connecting to upper level drivers */
		unsigned select_no_atn:1;
		unsigned fix_capacity:1; /* READ_CAPACITY is too high by 1 */

Admin message