Commit d27a3c34 authored Mar 21, 2018 by Colin Ian King Committed by Sudeep Holla Apr 16, 2018

firmware: arm_scmi: remove redundant null check on array



The null check on clk->name is redundant since name is a char array
and can never be null, so the check is always true.  Remove it.

Detected by CoverityScan, CID#1466117 ("Array compared against 0")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

parent 60cc43fc

drivers/firmware/arm_scmi/clock.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -284,7 +284,7 @@ scmi_clock_info_get(const struct scmi_handle *handle, u32 clk_id)
		struct clock_info *ci = handle->clk_priv;
		struct scmi_clock_info *clk = ci->clk + clk_id;

		if (!clk->name \|\| !clk->name[0])
		if (!clk->name[0])
		return NULL;

		return clk;

Admin message