Commit d276734d authored Oct 06, 2010 by Christoph Hellwig Committed by Alex Elder Oct 18, 2010

xfs: fix bogus m_maxagi check in xfs_iget



These days inode64 should only control which AGs we allocate new
inodes from, while we still try to support reading all existing
inodes.  To make this actually work the check ontop of xfs_iget
needs to be relaxed to allow inodes in all allocation groups instead
of just those that we allow allocating inodes from.  Note that we
can't simply remove the check - it prevents us from accessing
invalid data when fed invalid inode numbers from NFS or bulkstat.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Alex Elder <aelder@sgi.com>

parent 1b040712

fs/xfs/xfs_iget.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -365,8 +365,8 @@ xfs_iget(
		xfs_perag_t *pag;
		xfs_agino_t agino;

		/* the radix tree exists only in inode capable AGs */
		if (XFS_INO_TO_AGNO(mp, ino) >= mp->m_maxagi)
		/* reject inode numbers outside existing AGs */
		if (XFS_INO_TO_AGNO(mp, ino) >= mp->m_sb.sb_agcount)
		return EINVAL;

		/* get the perag structure and ensure that it's inode capable */

Admin message