Commit d271976d authored Sep 30, 2015 by Marc Zyngier

arm64: el2_setup: Make sure ICC_SRE_EL2.SRE sticks before using GICv3 sysregs



Contrary to what was originally expected, EL3 firmware can (for whatever
reason) disable GICv3 system register access. In this case, the kernel
explodes very early.

Work around this by testing if the SRE bit sticks or not. If it doesn't,
abort the GICv3 setup, and pray that the firmware has passed a DT that
doesn't contain a GICv3 node.

Reviewed-by: Catalin Marinas <catalin.marinas@arm.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>

parent 0e841b04

arch/arm64/kernel/head.S

+2 −0

Original line number	Diff line number	Diff line
		@@ -498,6 +498,8 @@ CPU_LE( bic x0, x0, #(3 << 24) ) // Clear the EE and E0E bits for EL1
		orr x0, x0, #ICC_SRE_EL2_ENABLE // Set ICC_SRE_EL2.Enable==1
		msr_s ICC_SRE_EL2, x0
		isb // Make sure SRE is now set
		mrs_s x0, ICC_SRE_EL2 // Read SRE back,
		tbz x0, #0, 3f // and check that it sticks
		msr_s ICH_HCR_EL2, xzr // Reset ICC_HCR_EL2 to defaults

		3:

Admin message