Commit d2665ca8 authored by Masahiro Yamada's avatar Masahiro Yamada
Browse files

modpost: refactor seen flag clearing in add_depends() 



You do not need to iterate over all modules for resetting ->seen flag
because add_depends() is only interested in modules that export symbols
referenced from the given 'mod'.

This also avoids shadowing the 'modules' parameter of add_depends().

Signed-off-by: default avatarMasahiro Yamada <yamada.masahiro@socionext.com>
parent f880eea6

scripts/mod/modpost.c

+6 −6
Original line number Diff line number Diff line
@@ -2241,15 +2241,15 @@ static int add_versions(struct buffer *b, struct module *mod) 
	return err;

}



static void add_depends(struct buffer *b, struct module *mod,

			struct module *modules)

static void add_depends(struct buffer *b, struct module *mod)

{

	struct symbol *s;

	struct module *m;

	int first = 1;



	for (m = modules; m; m = m->next)

		m->seen = is_vmlinux(m->name);

	/* Clear ->seen flag of modules that own symbols needed by this. */

	for (s = mod->unres; s; s = s->next)

		if (s->module)

			s->module->seen = is_vmlinux(s->module->name);



	buf_printf(b, "\n");

	buf_printf(b, "static const char __module_depends[]\n");
@@ -2518,7 +2518,7 @@ int main(int argc, char **argv) 
		add_retpoline(&buf);

		add_staging_flag(&buf, mod->name);

		err |= add_versions(&buf, mod);

		add_depends(&buf, mod, modules);

		add_depends(&buf, mod);

		add_moddevtable(&buf, mod);

		add_srcversion(&buf, mod);

CRA Git | Maintained and supported by SUSTech CRA and CCSE