Commit d2648d4e authored by Nicolas Schichan's avatar Nicolas Schichan Committed by David S. Miller
Browse files

test_bpf: add module parameters to filter the tests to run. 



When developping on the interpreter or a particular JIT, it can be
interesting to restrict the tests list to a specific test or a
particular range of tests.

This patch adds the following module parameters to the test_bpf module:

* test_name=<string>: only the specified named test will be run.

* test_id=<number>: only the test with the specified id will be run
  (see the output of test_bpf without parameters to get the test id).

* test_range=<number>,<number>: only the tests within IDs in the
  specified id range are run (see the output of test_bpf without
  parameters to get the test ids).

Any invalid range, test id or test name will result in -EINVAL being
returned and no tests being run.

Signed-off-by: default avatarNicolas Schichan <nschichan@freebox.fr>
Acked-by: default avatarDaniel Borkmann <daniel@iogearbox.net>
Acked-by: default avatarAlexei Starovoitov <ast@plumgrid.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 2cf1ad75

lib/test_bpf.c

+71 −0
Original line number Diff line number Diff line
@@ -4871,10 +4871,73 @@ static int run_one(const struct bpf_prog *fp, struct bpf_test *test) 
	return err_cnt;

}



static char test_name[64];

module_param_string(test_name, test_name, sizeof(test_name), 0);



static int test_id = -1;

module_param(test_id, int, 0);



static int test_range[2] = { 0, ARRAY_SIZE(tests) - 1 };

module_param_array(test_range, int, NULL, 0);



static __init int find_test_index(const char *test_name)

{

	int i;



	for (i = 0; i < ARRAY_SIZE(tests); i++) {

		if (!strcmp(tests[i].descr, test_name))

			return i;

	}

	return -1;

}



static __init int prepare_bpf_tests(void)

{

	int i;



	if (test_id >= 0) {

		/*

		 * if a test_id was specified, use test_range to

		 * cover only that test.

		 */

		if (test_id >= ARRAY_SIZE(tests)) {

			pr_err("test_bpf: invalid test_id specified.\n");

			return -EINVAL;

		}



		test_range[0] = test_id;

		test_range[1] = test_id;

	} else if (*test_name) {

		/*

		 * if a test_name was specified, find it and setup

		 * test_range to cover only that test.

		 */

		int idx = find_test_index(test_name);



		if (idx < 0) {

			pr_err("test_bpf: no test named '%s' found.\n",

			       test_name);

			return -EINVAL;

		}

		test_range[0] = idx;

		test_range[1] = idx;

	} else {

		/*

		 * check that the supplied test_range is valid.

		 */

		if (test_range[0] >= ARRAY_SIZE(tests) ||

		    test_range[1] >= ARRAY_SIZE(tests) ||

		    test_range[0] < 0 || test_range[1] < 0) {

			pr_err("test_bpf: test_range is out of bound.\n");

			return -EINVAL;

		}



		if (test_range[1] < test_range[0]) {

			pr_err("test_bpf: test_range is ending before it starts.\n");

			return -EINVAL;

		}

	}



	for (i = 0; i < ARRAY_SIZE(tests); i++) {

		if (tests[i].fill_helper &&

		    tests[i].fill_helper(&tests[i]) < 0)
@@ -4894,6 +4957,11 @@ static __init void destroy_bpf_tests(void) 
	}

}



static bool exclude_test(int test_id)

{

	return test_id < test_range[0] || test_id > test_range[1];

}



static __init int test_bpf(void)

{

	int i, err_cnt = 0, pass_cnt = 0;
@@ -4903,6 +4971,9 @@ static __init int test_bpf(void) 
		struct bpf_prog *fp;

		int err;



		if (exclude_test(i))

			continue;



		pr_info("#%d %s ", i, tests[i].descr);



		fp = generate_filter(i, &err);

CRA Git | Maintained and supported by SUSTech CRA and CCSE