Commit d2598bb8 authored Aug 25, 2020 by Alex Dewar Committed by Jason Gunthorpe Aug 31, 2020

RDMA/qib: Remove superfluous fallthrough statements

Commit 36a8f01c ("IB/qib: Add congestion control agent
implementation") erroneously marked a couple of switch cases as /*
FALLTHROUGH */, which were later converted to fallthrough statements by
commit df561f66 ("treewide: Use fallthrough pseudo-keyword"). This
triggered a Coverity warning about unreachable code.

Remove the fallthrough statements.

Link: https://lore.kernel.org/r/20200825171242.448447-1-alex.dewar90@gmail.com


Addresses-Coverity: ("Unreachable code")
Fixes: 36a8f01c ("IB/qib: Add congestion control agent implementation")
Signed-off-by: Alex Dewar <alex.dewar90@gmail.com>
Reviewed-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>

parent 6989aa62

drivers/infiniband/hw/qib/qib_mad.c

+0 −2

Original line number	Diff line number	Diff line
		@@ -2322,7 +2322,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags,
		ret = cc_get_congestion_control_table(ccp, ibdev, port);
		goto bail;

		fallthrough;
		default:
		ccp->status \|= IB_SMP_UNSUP_METH_ATTR;
		ret = reply((struct ib_smp *) ccp);
		@@ -2339,7 +2338,6 @@ static int process_cc(struct ib_device *ibdev, int mad_flags,
		ret = cc_set_congestion_control_table(ccp, ibdev, port);
		goto bail;

		fallthrough;
		default:
		ccp->status \|= IB_SMP_UNSUP_METH_ATTR;
		ret = reply((struct ib_smp *) ccp);

Admin message