Commit d250a5f9 authored by Eric Dumazet's avatar Eric Dumazet Committed by David S. Miller
Browse files

pkt_sched: gen_estimator: Dont report fake rate estimators 



Jarek Poplawski a écrit :
>
>
> Hmm... So you made me to do some "real" work here, and guess what?:
> there is one serious checkpatch warning! ;-) Plus, this new parameter
> should be added to the function description. Otherwise:
> Signed-off-by: default avatarJarek Poplawski <jarkao2@gmail.com>
>
> Thanks,
> Jarek P.
>
> PS: I guess full "Don't" would show we really mean it...

Okay :) Here is the last round, before the night !

Thanks again

[RFC] pkt_sched: gen_estimator: Don't report fake rate estimators

We currently send TCA_STATS_RATE_EST elements to netlink users, even if no estimator
is running.

# tc -s -d qdisc
qdisc pfifo_fast 0: dev eth0 root bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
 Sent 112833764978 bytes 1495081739 pkt (dropped 0, overlimits 0 requeues 0)
 rate 0bit 0pps backlog 0b 0p requeues 0

User has no way to tell if the "rate 0bit 0pps" is a real estimation, or a fake
one (because no estimator is active)

After this patch, tc command output is :
$ tc -s -d qdisc
qdisc pfifo_fast 0: dev eth0 root bands 3 priomap  1 2 2 2 1 2 0 0 1 1 1 1 1 1 1 1
 Sent 561075 bytes 1196 pkt (dropped 0, overlimits 0 requeues 0)
 backlog 0b 0p requeues 0

We add a parameter to gnet_stats_copy_rate_est() function so that
it can use gen_estimator_active(bstats, r), as suggested by Jarek.

This parameter can be NULL if check is not necessary, (htb for
example has a mandatory rate estimator)

Signed-off-by: default avatarEric Dumazet <eric.dumazet@gmail.com>
Signed-off-by: default avatarJarek Poplawski <jarkao2@gmail.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 92d326f6

include/net/gen_stats.h

+1 −0
Original line number Diff line number Diff line
@@ -30,6 +30,7 @@ extern int gnet_stats_start_copy_compat(struct sk_buff *skb, int type, 
extern int gnet_stats_copy_basic(struct gnet_dump *d,

				 struct gnet_stats_basic_packed *b);

extern int gnet_stats_copy_rate_est(struct gnet_dump *d,

				    const struct gnet_stats_basic_packed *b,

				    struct gnet_stats_rate_est *r);

extern int gnet_stats_copy_queue(struct gnet_dump *d,

				 struct gnet_stats_queue *q);

net/core/gen_stats.c

+7 −1
Original line number Diff line number Diff line
@@ -127,6 +127,7 @@ gnet_stats_copy_basic(struct gnet_dump *d, struct gnet_stats_basic_packed *b) 
/**

 * gnet_stats_copy_rate_est - copy rate estimator statistics into statistics TLV

 * @d: dumping handle

 * @b: basic statistics

 * @r: rate estimator statistics

 *

 * Appends the rate estimator statistics to the top level TLV created by
@@ -136,8 +137,13 @@ gnet_stats_copy_basic(struct gnet_dump *d, struct gnet_stats_basic_packed *b) 
 * if the room in the socket buffer was not sufficient.

 */

int

gnet_stats_copy_rate_est(struct gnet_dump *d, struct gnet_stats_rate_est *r)

gnet_stats_copy_rate_est(struct gnet_dump *d,

			 const struct gnet_stats_basic_packed *b,

			 struct gnet_stats_rate_est *r)

{

	if (b && !gen_estimator_active(b, r))

		return 0;



	if (d->compat_tc_stats) {

		d->tc_stats.bps = r->bps;

		d->tc_stats.pps = r->pps;

net/sched/act_api.c

+2 −1
Original line number Diff line number Diff line
@@ -618,7 +618,8 @@ int tcf_action_copy_stats(struct sk_buff *skb, struct tc_action *a, 
			goto errout;



	if (gnet_stats_copy_basic(&d, &h->tcf_bstats) < 0 ||

	    gnet_stats_copy_rate_est(&d, &h->tcf_rate_est) < 0 ||

	    gnet_stats_copy_rate_est(&d, &h->tcf_bstats,

				     &h->tcf_rate_est) < 0 ||

	    gnet_stats_copy_queue(&d, &h->tcf_qstats) < 0)

		goto errout;

net/sched/sch_api.c

+1 −1
Original line number Diff line number Diff line
@@ -1179,7 +1179,7 @@ static int tc_fill_qdisc(struct sk_buff *skb, struct Qdisc *q, u32 clid, 
		goto nla_put_failure;



	if (gnet_stats_copy_basic(&d, &q->bstats) < 0 ||

	    gnet_stats_copy_rate_est(&d, &q->rate_est) < 0 ||

	    gnet_stats_copy_rate_est(&d, &q->bstats, &q->rate_est) < 0 ||

	    gnet_stats_copy_queue(&d, &q->qstats) < 0)

		goto nla_put_failure;

net/sched/sch_cbq.c

+1 −1
Original line number Diff line number Diff line
@@ -1609,7 +1609,7 @@ cbq_dump_class_stats(struct Qdisc *sch, unsigned long arg, 
		cl->xstats.undertime = cl->undertime - q->now;



	if (gnet_stats_copy_basic(d, &cl->bstats) < 0 ||

	    gnet_stats_copy_rate_est(d, &cl->rate_est) < 0 ||

	    gnet_stats_copy_rate_est(d, &cl->bstats, &cl->rate_est) < 0 ||

	    gnet_stats_copy_queue(d, &cl->qstats) < 0)

		return -1;

CRA Git | Maintained and supported by SUSTech CRA and CCSE