Commit d247b035 authored by Madhumitha Prabakaran's avatar Madhumitha Prabakaran Committed by Greg Kroah-Hartman
Browse files

Staging: rtl8192u: ieee80211: Remove custom macro IEEE80211_DEBUG 



Remove the custom macro IEEE80211_DEBUG for printing message in
dev_alloc_skb in order to maintain Linux kernel coding style based on
which kernel does not print failure warning.

Issue suggested by Coccinelle

Signed-off-by: default avatarMadhumitha Prabakaran <madhumithabiw@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 8eaade88

drivers/staging/rtl8192u/ieee80211/rtl819x_BAProc.c

+2 −6
Original line number Diff line number Diff line
@@ -118,10 +118,8 @@ static struct sk_buff *ieee80211_ADDBA(struct ieee80211_device *ieee, u8 *Dst, s 
		return NULL;

	}

	skb = dev_alloc_skb(len + sizeof(struct rtl_80211_hdr_3addr)); //need to add something others? FIXME

	if (!skb) {

		IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc skb for ADDBA_REQ\n");

	if (!skb)

		return NULL;

	}



	memset(skb->data, 0, sizeof(struct rtl_80211_hdr_3addr));	//I wonder whether it's necessary. Apparently kernel will not do it when alloc a skb.

	skb_reserve(skb, ieee->tx_headroom);
@@ -205,10 +203,8 @@ static struct sk_buff *ieee80211_DELBA( 
	DelbaParamSet.field.tid	= pBA->param_set.field.tid;



	skb = dev_alloc_skb(len + sizeof(struct rtl_80211_hdr_3addr)); //need to add something others? FIXME

	if (!skb) {

		IEEE80211_DEBUG(IEEE80211_DL_ERR, "can't alloc skb for ADDBA_REQ\n");

	if (!skb)

		return NULL;

	}

//	memset(skb->data, 0, len+sizeof( struct rtl_80211_hdr_3addr));

	skb_reserve(skb, ieee->tx_headroom);

CRA Git | Maintained and supported by SUSTech CRA and CCSE