Commit d22b115c authored by Gavin Shan's avatar Gavin Shan Committed by Catalin Marinas
Browse files

arm64/kernel: Simplify __cpu_up() by bailing out early 



The function __cpu_up() is invoked to bring up the target CPU through
the backend, PSCI for example. The nested if statements won't be needed
if we bail out early on the following two conditions where the status
won't be checked. The code looks simplified in that case.

   * Error returned from the backend (e.g. PSCI)
   * The target CPU has been marked as onlined

Signed-off-by: default avatarGavin Shan <gshan@redhat.com>
Signed-off-by: default avatarCatalin Marinas <catalin.marinas@arm.com>
Reviewed-by: default avatarMark Rutland <mark.rutland@arm.com>
parent 24b2cce9

arch/arm64/kernel/smp.c

+37 −42
Original line number Diff line number Diff line
@@ -115,33 +115,27 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) 
	update_cpu_boot_status(CPU_MMU_OFF);

	__flush_dcache_area(&secondary_data, sizeof(secondary_data));



	/*

	 * Now bring the CPU into our world.

	 */

	/* Now bring the CPU into our world */

	ret = boot_secondary(cpu, idle);

	if (ret == 0) {

	if (ret) {

		pr_err("CPU%u: failed to boot: %d\n", cpu, ret);

		return ret;

	}



	/*

	 * CPU was successfully started, wait for it to come online or

	 * time out.

	 */

	wait_for_completion_timeout(&cpu_running,

				    msecs_to_jiffies(5000));

	if (cpu_online(cpu))

		return 0;



		if (!cpu_online(cpu)) {

	pr_crit("CPU%u: failed to come online\n", cpu);

			ret = -EIO;

		}

	} else {

		pr_err("CPU%u: failed to boot: %d\n", cpu, ret);

		return ret;

	}



	secondary_data.task = NULL;

	secondary_data.stack = NULL;

	__flush_dcache_area(&secondary_data, sizeof(secondary_data));

	status = READ_ONCE(secondary_data.status);

	if (ret && status) {



	if (status == CPU_MMU_OFF)

		status = READ_ONCE(__early_cpu_boot_status);
@@ -162,14 +156,15 @@ int __cpu_up(unsigned int cpu, struct task_struct *idle) 
		pr_crit("CPU%u: is stuck in kernel\n", cpu);

		if (status & CPU_STUCK_REASON_52_BIT_VA)

			pr_crit("CPU%u: does not support 52-bit VAs\n", cpu);

			if (status & CPU_STUCK_REASON_NO_GRAN)

				pr_crit("CPU%u: does not support %luK granule \n", cpu, PAGE_SIZE / SZ_1K);

		if (status & CPU_STUCK_REASON_NO_GRAN) {

			pr_crit("CPU%u: does not support %luK granule\n",

				cpu, PAGE_SIZE / SZ_1K);

		}

		cpus_stuck_in_kernel++;

		break;

	case CPU_PANIC_KERNEL:

		panic("CPU%u detected unsupported configuration\n", cpu);

	}

	}



	return ret;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE