Commit d1f5050b authored May 04, 2019 by Heiner Kallweit Committed by David S. Miller May 05, 2019

r8169: speed up rtl_loop_wait



When testing I figured out that most operations signal finish even
before we trigger the first delay. Seems like PCI(e) access and
memory barriers typically add enough latency. Therefore move the
first delay after the first check.

Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 9cf9b84c

drivers/net/ethernet/realtek/r8169.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -775,9 +775,9 @@ static bool rtl_loop_wait(struct rtl8169_private tp, const struct rtl_cond c,
		int i;

		for (i = 0; i < n; i++) {
		delay(d);
		if (c->check(tp) == high)
		return true;
		delay(d);
		}
		netif_err(tp, drv, tp->dev, "%s == %d (loop: %d, delay: %d).\n",
		c->msg, !high, n, d);

Admin message