Commit d1c72f6e authored May 20, 2020 by Iuliana Prodan Committed by Herbert Xu May 28, 2020

crypto: engine - do not requeue in case of fatal error



Now, in crypto-engine, if hardware queue is full (-ENOSPC),
requeue request regardless of MAY_BACKLOG flag.
If hardware throws any other error code (like -EIO, -EINVAL,
-ENOMEM, etc.) only MAY_BACKLOG requests are enqueued back into
crypto-engine's queue, since the others can be dropped.
The latter case can be fatal error, so those cannot be recovered from.
For example, in CAAM driver, -EIO is returned in case the job descriptor
is broken, so there is no possibility to fix the job descriptor.
Therefore, these errors might be fatal error, so we shouldn’t
requeue the request. This will just be pass back and forth between
crypto-engine and hardware.

Fixes: 6a89f492 ("crypto: engine - support for parallel requests based on retry mechanism")
Signed-off-by: Iuliana Prodan <iuliana.prodan@nxp.com>
Reported-by: Horia Geantă <horia.geanta@nxp.com>
Reviewed-by: Horia Geantă <horia.geanta@nxp.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent ae4052c5

crypto/crypto_engine.c

+1 −4

Original line number	Diff line number	Diff line
		@@ -169,13 +169,10 @@ start_request:
		/*
		* If hardware queue is full (-ENOSPC), requeue request
		* regardless of backlog flag.
		* If hardware throws any other error code,
		* requeue only backlog requests.
		* Otherwise, unprepare and complete the request.
		*/
		if (!engine->retry_support \|\|
		((ret != -ENOSPC) &&
		!(async_req->flags & CRYPTO_TFM_REQ_MAY_BACKLOG))) {
		(ret != -ENOSPC)) {
		dev_err(engine->dev,
		"Failed to do one request from queue: %d\n",
		ret);

Admin message