Commit d1b9ae18 authored Dec 23, 2019 by Alexandra Winter Committed by David S. Miller Dec 24, 2019

s390/qeth: vnicc Fix init to default



During vnicc_init wanted_char should be compared to cur_char and not
to QETH_VNICC_DEFAULT. Without this patch there is no way to enforce
the default values as desired values.

Note, that it is expected, that a card comes online with default values.
This patch was tested with private card firmware.

Fixes: caa1f0b1 ("s390/qeth: add VNICC enable/disable support")
Signed-off-by: Alexandra Winter <wintera@linux.ibm.com>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent e8a66d80

drivers/s390/net/qeth_l2_main.c

+3 −1

Original line number	Diff line number	Diff line
		@@ -2039,7 +2039,9 @@ static void qeth_l2_vnicc_init(struct qeth_card *card)
		/* enforce assumed default values and recover settings, if changed */
		error \|= qeth_l2_vnicc_recover_timeout(card, QETH_VNICC_LEARNING,
		timeout);
		chars_tmp = card->options.vnicc.wanted_chars ^ QETH_VNICC_DEFAULT;
		/* Change chars, if necessary */
		chars_tmp = card->options.vnicc.wanted_chars ^
		card->options.vnicc.cur_chars;
		chars_len = sizeof(card->options.vnicc.wanted_chars) * BITS_PER_BYTE;
		for_each_set_bit(i, &chars_tmp, chars_len) {
		vnicc = BIT(i);

Admin message