Commit d19d8d34 authored Nov 10, 2020 by Eric Biggers

fscrypt: fix inline encryption not used on new files



The new helper function fscrypt_prepare_new_inode() runs before
S_ENCRYPTED has been set on the new inode.  This accidentally made
fscrypt_select_encryption_impl() never enable inline encryption on newly
created files, due to its use of fscrypt_needs_contents_encryption()
which only returns true when S_ENCRYPTED is set.

Fix this by using S_ISREG() directly instead of
fscrypt_needs_contents_encryption(), analogous to what
select_encryption_mode() does.

I didn't notice this earlier because by design, the user-visible
behavior is the same (other than performance, potentially) regardless of
whether inline encryption is used or not.

Fixes: a992b20c ("fscrypt: add fscrypt_prepare_new_inode() and fscrypt_set_context()")
Reviewed-by: Satya Tangirala <satyat@google.com>
Link: https://lore.kernel.org/r/20201111015224.303073-1-ebiggers@kernel.org


Signed-off-by: Eric Biggers <ebiggers@google.com>

parent 92cfcd03

fs/crypto/inline_crypt.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -74,7 +74,7 @@ int fscrypt_select_encryption_impl(struct fscrypt_info *ci)
		int i;

		/* The file must need contents encryption, not filenames encryption */
		if (!fscrypt_needs_contents_encryption(inode))
		if (!S_ISREG(inode->i_mode))
		return 0;

		/* The crypto mode must have a blk-crypto counterpart */

Admin message