Commit d1933689 authored Jan 24, 2014 by Emilio López Committed by Mike Turquette Jan 27, 2014

clk: sunxi: fix overflow when setting up divided factors



Currently, we are allocating space for two pointers, when we actually
may need to store three of them (two divisors plus the original clock).
Fix this, and change sizeof(type) to sizeof(*var) to keep checkpatch.pl
happy.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Emilio López <emilio@elopez.com.ar>
Signed-off-by: Mike Turquette <mturquette@linaro.org>

parent 0b7f04b8

drivers/clk/sunxi/clk-sunxi.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -875,7 +875,7 @@ static void __init sunxi_divs_clk_setup(struct device_node *node,
		if (!clk_data)
		return;

		clks = kzalloc(SUNXI_DIVS_MAX_QTY * sizeof(struct clk *), GFP_KERNEL);
		clks = kzalloc((SUNXI_DIVS_MAX_QTY+1) * sizeof(*clks), GFP_KERNEL);
		if (!clks)
		goto free_clkdata;

Admin message