Commit d1889589 authored Oct 26, 2020 by Sven Joachim Committed by Masahiro Yamada Nov 02, 2020

builddeb: Fix rootless build in setuid/setgid directory



Building 5.10-rc1 in a setgid directory failed with the following
error:

dpkg-deb: error: control directory has bad permissions 2755 (must be
>=0755 and <=0775)

When building with fakeroot, the earlier chown call would have removed
the setgid bits, but in a rootless build they remain.

Fixes: 3e854180 ("builddeb: Enable rootless builds")
Cc: Guillem Jover <guillem@hadrons.org>
Signed-off-by: Sven Joachim <svenjoac@gmx.de>
Signed-off-by: Masahiro Yamada <masahiroy@kernel.org>

parent d9b5665f

scripts/package/builddeb

+2 −0

Original line number	Diff line number	Diff line
		@@ -45,6 +45,8 @@ create_package() {
		chmod -R go-w "$pdir"
		# in case we are in a restrictive umask environment like 0077
		chmod -R a+rX "$pdir"
		# in case we build in a setuid/setgid directory
		chmod -R ug-s "$pdir"

		# Create the package
		dpkg-gencontrol -p$pname -P"$pdir"

Admin message