Commit d180870d authored Apr 20, 2020 by Michal Hocko Committed by Linus Torvalds Apr 21, 2020

mm, gup: return EINTR when gup is interrupted by fatal signals



EINTR is the usual error code which other killable interfaces return.
This is the case for the other fatal_signal_pending break out from the
same function.  Make the code consistent.

ERESTARTSYS is also quite confusing because the signal is fatal and so
no restart will happen before returning to the userspace.

Signed-off-by: Michal Hocko <mhocko@suse.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Acked-by: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Xu <peterx@redhat.com>
Cc: Hillf Danton <hdanton@sina.com>
Link: http://lkml.kernel.org/r/20200409071133.31734-1-mhocko@kernel.org


Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 3c1d7e6c

mm/gup.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -1088,7 +1088,7 @@ retry:
		* potentially allocating memory.
		*/
		if (fatal_signal_pending(current)) {
		ret = -ERESTARTSYS;
		ret = -EINTR;
		goto out;
		}
		cond_resched();

Admin message