Commit d17465a0 authored by Bartosz Golaszewski's avatar Bartosz Golaszewski Committed by Lee Jones
Browse files

backlight: gpio: Use a helper variable for &pdev->dev



Instead of dereferencing pdev each time, use a helper variable for
the associated device pointer.

Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
Reviewed-by: default avatarLinus Walleij <linus.walleij@linaro.org>
Reviewed-by: default avatarDaniel Thompson <daniel.thompson@linaro.org>
Reviewed-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent 2e7ec69d
Loading
Loading
Loading
Loading
+11 −12
Original line number Diff line number Diff line
@@ -78,29 +78,29 @@ static int gpio_backlight_initial_power_state(struct gpio_backlight *gbl)

static int gpio_backlight_probe(struct platform_device *pdev)
{
	struct gpio_backlight_platform_data *pdata =
		dev_get_platdata(&pdev->dev);
	struct device *dev = &pdev->dev;
	struct gpio_backlight_platform_data *pdata = dev_get_platdata(dev);
	struct backlight_properties props;
	struct backlight_device *bl;
	struct gpio_backlight *gbl;
	int ret, init_brightness;

	gbl = devm_kzalloc(&pdev->dev, sizeof(*gbl), GFP_KERNEL);
	gbl = devm_kzalloc(dev, sizeof(*gbl), GFP_KERNEL);
	if (gbl == NULL)
		return -ENOMEM;

	gbl->dev = &pdev->dev;
	gbl->dev = dev;

	if (pdata)
		gbl->fbdev = pdata->fbdev;

	gbl->def_value = device_property_read_bool(&pdev->dev, "default-on");
	gbl->def_value = device_property_read_bool(dev, "default-on");

	gbl->gpiod = devm_gpiod_get(&pdev->dev, NULL, GPIOD_ASIS);
	gbl->gpiod = devm_gpiod_get(dev, NULL, GPIOD_ASIS);
	if (IS_ERR(gbl->gpiod)) {
		ret = PTR_ERR(gbl->gpiod);
		if (ret != -EPROBE_DEFER)
			dev_err(&pdev->dev,
			dev_err(dev,
				"Error: The gpios parameter is missing or invalid.\n");
		return ret;
	}
@@ -108,11 +108,10 @@ static int gpio_backlight_probe(struct platform_device *pdev)
	memset(&props, 0, sizeof(props));
	props.type = BACKLIGHT_RAW;
	props.max_brightness = 1;
	bl = devm_backlight_device_register(&pdev->dev, dev_name(&pdev->dev),
					&pdev->dev, gbl, &gpio_backlight_ops,
					&props);
	bl = devm_backlight_device_register(dev, dev_name(dev), dev, gbl,
					    &gpio_backlight_ops, &props);
	if (IS_ERR(bl)) {
		dev_err(&pdev->dev, "failed to register backlight\n");
		dev_err(dev, "failed to register backlight\n");
		return PTR_ERR(bl);
	}

@@ -122,7 +121,7 @@ static int gpio_backlight_probe(struct platform_device *pdev)
	init_brightness = gpio_backlight_get_next_brightness(bl);
	ret = gpiod_direction_output(gbl->gpiod, init_brightness);
	if (ret) {
		dev_err(&pdev->dev, "failed to set initial brightness\n");
		dev_err(dev, "failed to set initial brightness\n");
		return ret;
	}