Bluetooth: Remove redundant check on status (d17010bf) · Commits · 戴 / test

The check on status is redundant as a status has to be zero at the point it is being checked because of a previous check and return path via label 'unlock'. Remove the redundant check and the deadcode that can never be reached. Detected by CoverityScan, CID#1471710 ("Logically dead code") Signed-off-by:

Colin Ian King <colin.king@canonical.com> Signed-off-by:

Marcel Holtmann <marcel@holtmann.org>

net/bluetooth/hci_event.c

+17 −21

Original line number	Diff line number	Diff line
		@@ -4937,7 +4937,6 @@ static void le_conn_complete_evt(struct hci_dev *hdev, u8 status,
		hci_debugfs_create_conn(conn);
		hci_conn_add_sysfs(conn);

		if (!status) {
		/* The remote features procedure is defined for master
		* role only. So only in case of an initiated connection
		* request the remote features.
		@@ -4961,9 +4960,6 @@ static void le_conn_complete_evt(struct hci_dev *hdev, u8 status,
		conn->state = BT_CONNECTED;
		hci_connect_cfm(conn, status);
		}
		} else {
		hci_connect_cfm(conn, status);
		}

		params = hci_pend_le_action_lookup(&hdev->pend_le_conns, &conn->dst,
		conn->dst_type);

Admin message