Commit d1645e52 authored Oct 18, 2008 by Hidehiro Kawai Committed by Linus Torvalds Oct 20, 2008

jbd: abort when failed to log metadata buffers



If we failed to write metadata buffers to the journal space and succeeded
to write the commit record, stale data can be written back to the
filesystem as metadata in the recovery phase.

To avoid this, when we failed to write out metadata buffers, abort the
journal before writing the commit record.

Signed-off-by: Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>
Acked-by: Jan Kara <jack@suse.cz>
Cc: <linux-ext4@vger.kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 60c11d2a

fs/jbd/commit.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -762,6 +762,9 @@ wait_for_iobuf:
		/* AKPM: bforget here */
		}

		if (err)
		journal_abort(journal, err);

		jbd_debug(3, "JBD: commit phase 6\n");

		if (journal_write_commit_record(journal, commit_transaction))

Admin message