Commit d15f5ac8 authored Dec 20, 2018 by Herbert Xu Committed by David S. Miller Dec 20, 2018

ipv6: frags: Fix bogus skb->sk in reassembled packets



It was reported that IPsec would crash when it encounters an IPv6
reassembled packet because skb->sk is non-zero and not a valid
pointer.

This is because skb->sk is now a union with ip_defrag_offset.

This patch fixes this by resetting skb->sk when exiting from
the reassembly code.

Reported-by: Xiumei Mu <xmu@redhat.com>
Fixes: 219badfa ("ipv6: frags: get rid of ip6frag_skb_cb/...")
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 8fd1a4af

net/ipv6/reassembly.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -384,6 +384,7 @@ static int ip6_frag_reasm(struct frag_queue fq, struct sk_buff prev,
		if (skb_try_coalesce(head, fp, &headstolen, &delta)) {
		kfree_skb_partial(fp, headstolen);
		} else {
		fp->sk = NULL;
		if (!skb_shinfo(head)->frag_list)
		skb_shinfo(head)->frag_list = fp;
		head->data_len += fp->len;

Admin message