Commit d15e35da authored by Thomas Zimmermann's avatar Thomas Zimmermann
Browse files

drm/udl: Don't track number of identical and sent pixels per line 



A call to udl_render_hline() returns the number of identical and
sent pixels. None of these values is used. Remove the parameters.

Signed-off-by: default avatarThomas Zimmermann <tzimmermann@suse.de>
Reviewed-by: default avatarEmil Velikov <emil.velikov@collabora.com>
Acked-by: default avatarGerd Hoffmann <kraxel@redhat.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20191206085954.9697-3-tzimmermann@suse.de
parent 3f1939b5

drivers/gpu/drm/udl/udl_drv.h

+1 −2
Original line number Diff line number Diff line
@@ -93,8 +93,7 @@ udl_fb_user_fb_create(struct drm_device *dev, 


int udl_render_hline(struct drm_device *dev, int log_bpp, struct urb **urb_ptr,

		     const char *front, char **urb_buf_ptr,

		     u32 byte_offset, u32 device_byte_offset, u32 byte_width,

		     int *ident_ptr, int *sent_ptr);

		     u32 byte_offset, u32 device_byte_offset, u32 byte_width);



struct drm_gem_object *udl_driver_gem_create_object(struct drm_device *dev,

						    size_t size);

drivers/gpu/drm/udl/udl_fb.c

+1 −5
Original line number Diff line number Diff line
@@ -68,8 +68,6 @@ int udl_handle_damage(struct drm_framebuffer *fb, int x, int y, 
	struct udl_device *udl = to_udl(dev);

	int i, ret;

	char *cmd;

	int bytes_sent = 0;

	int bytes_identical = 0;

	struct urb *urb;

	int aligned_x;

	int log_bpp;
@@ -115,8 +113,7 @@ int udl_handle_damage(struct drm_framebuffer *fb, int x, int y, 
		const int dev_byte_offset = (fb->width * i + x) << log_bpp;

		if (udl_render_hline(dev, log_bpp, &urb, (char *)vaddr,

				     &cmd, byte_offset, dev_byte_offset,

				     width << log_bpp,

				     &bytes_identical, &bytes_sent))

				     width << log_bpp))

			goto out;

	}
@@ -127,7 +124,6 @@ int udl_handle_damage(struct drm_framebuffer *fb, int x, int y, 
			*cmd++ = 0xAF;

		len = cmd - (char *) urb->transfer_buffer;

		ret = udl_submit_urb(dev, urb, len);

		bytes_sent += len;

	} else

		udl_urb_completion(urb);

drivers/gpu/drm/udl/udl_transfer.c

+1 −3
Original line number Diff line number Diff line
@@ -212,8 +212,7 @@ static void udl_compress_hline16( 
int udl_render_hline(struct drm_device *dev, int log_bpp, struct urb **urb_ptr,

		     const char *front, char **urb_buf_ptr,

		     u32 byte_offset, u32 device_byte_offset,

		     u32 byte_width,

		     int *ident_ptr, int *sent_ptr)

		     u32 byte_width)

{

	const u8 *line_start, *line_end, *next_pixel;

	u32 base16 = 0 + (device_byte_offset >> log_bpp) * 2;
@@ -237,7 +236,6 @@ int udl_render_hline(struct drm_device *dev, int log_bpp, struct urb **urb_ptr, 
			int len = cmd - (u8 *) urb->transfer_buffer;

			if (udl_submit_urb(dev, urb, len))

				return 1; /* lost pixels is set */

			*sent_ptr += len;

			urb = udl_get_urb(dev);

			if (!urb)

				return 1; /* lost_pixels is set */

CRA Git | Maintained and supported by SUSTech CRA and CCSE