Commit d148bbd3 authored Feb 12, 2016 by David Rivshin Committed by David S. Miller Feb 17, 2016

drivers: net: cpsw-phy-sel: add dev_warn() for unsupported PHY mode



The cpsw-phy-sel driver supports only MII, RMII, and RGMII PHY modes,
and silently handled any other values as if MII was specified. In a
case where the PHY mode was incorrectly specified, or a bug elsewhere,
there would be no indication of a problem. If MII was the correct mode,
then this will go unnoticed, otherwise the symptom will be a failure
to transmit/receive data over the RMII/RGMII link.

Add a dev_warn() to make this condition obvious and provide a
breadcrumb to follow.

Cc: Mugunthan V N <mugunthanvnm@ti.com>
Signed-off-by: David Rivshin <drivshin@allworx.com>
Acked-by: Mugunthan V N <mugunthanvnm@ti.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent cd772de3

drivers/net/ethernet/ti/cpsw-phy-sel.c

+10 −2

Original line number	Diff line number	Diff line
		@@ -63,8 +63,12 @@ static void cpsw_gmii_sel_am3352(struct cpsw_phy_sel_priv *priv,
		mode = AM33XX_GMII_SEL_MODE_RGMII;
		break;

		case PHY_INTERFACE_MODE_MII:
		default:
		dev_warn(priv->dev,
		"Unsupported PHY mode: \"%s\". Defaulting to MII.\n",
		phy_modes(phy_mode));
		/* fallthrough */
		case PHY_INTERFACE_MODE_MII:
		mode = AM33XX_GMII_SEL_MODE_MII;
		break;
		};
		@@ -106,8 +110,12 @@ static void cpsw_gmii_sel_dra7xx(struct cpsw_phy_sel_priv *priv,
		mode = AM33XX_GMII_SEL_MODE_RGMII;
		break;

		case PHY_INTERFACE_MODE_MII:
		default:
		dev_warn(priv->dev,
		"Unsupported PHY mode: \"%s\". Defaulting to MII.\n",
		phy_modes(phy_mode));
		/* fallthrough */
		case PHY_INTERFACE_MODE_MII:
		mode = AM33XX_GMII_SEL_MODE_MII;
		break;
		};

Admin message