rtc: pcap: set range (d1403c48) · Commits · 戴 / test

While PCAP_RTC_DAY_MASK is set to 0x3ffff, it is very unlikely to be correct as this ends in june 1992, before the product even existed. It is more likely to be a 14-bit day counter. The next product in the family (the mc13xxx) has a 15-bit day counter. The same issue is seen with PCAP_RTC_TOD_MASK which only has 65535 seconds and falls short of the necessary 86400 seconds. Signed-off-by:

Alexandre Belloni <alexandre.belloni@bootlin.com>

drivers/rtc/rtc-pcap.c

+5 −3

Original line number	Diff line number	Diff line
		@@ -149,11 +149,13 @@ static int __init pcap_rtc_probe(struct platform_device *pdev)

		platform_set_drvdata(pdev, pcap_rtc);

		pcap_rtc->rtc = devm_rtc_device_register(&pdev->dev, "pcap",
		&pcap_rtc_ops, THIS_MODULE);
		pcap_rtc->rtc = devm_rtc_allocate_device(&pdev->dev);
		if (IS_ERR(pcap_rtc->rtc))
		return PTR_ERR(pcap_rtc->rtc);

		pcap_rtc->rtc->ops = &pcap_rtc_ops;
		pcap_rtc->rtc->range_max = (1 << 14) * 86400ULL - 1;

		timer_irq = pcap_to_irq(pcap_rtc->pcap, PCAP_IRQ_1HZ);
		alarm_irq = pcap_to_irq(pcap_rtc->pcap, PCAP_IRQ_TODA);

		@@ -167,7 +169,7 @@ static int __init pcap_rtc_probe(struct platform_device *pdev)
		if (err)
		return err;

		return 0;
		return rtc_register_device(pcap_rtc->rtc);
		}

		static int __exit pcap_rtc_remove(struct platform_device *pdev)

Admin message