Commit d12392ec authored Oct 20, 2011 by Sylwester Nawrocki Committed by Mauro Carvalho Chehab Nov 24, 2011

[media] s5p-fimc: Fail driver probing when sensor configuration is wrong



When a sensor with MIPI-CSI interface is attached through platform
data definition and the MIPI-CSI receiver is not selected in kernel
configuration s5p-fimc driver probe() will now succeed, issuing only
a warning. It was done this way to allow the driver to work even if
system configuration is not exactly right.

Instead make the driver's probe() fail if a MIPI-CSI sensor was
requested but s5p-csis module is not present.

Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@redhat.com>

parent 9c63afcb

drivers/media/video/s5p-fimc/fimc-mdevice.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -514,7 +514,7 @@ static int fimc_md_create_links(struct fimc_md *fmd)
		if (WARN(csis == NULL,
		"MIPI-CSI interface specified "
		"but s5p-csis module is not loaded!\n"))
		continue;
		return -EINVAL;

		ret = media_entity_create_link(&sensor->entity, 0,
		&csis->entity, CSIS_PAD_SINK,

Admin message