Commit d11f54b7 authored Mar 04, 2017 by James Smart Committed by Martin K. Petersen Mar 06, 2017

scsi: lpfc: fix missing spin_unlock on sql_list_lock



From: Colin Ian King <colin.king@canonical.com>

In the case where sglq is null, the current code just returns without
unlocking the spinlock sql_list_lock. Fix this by breaking out of the
while loop and the exit path will then unlock and return NULL as was
the original intention.

Detected by CoverityScan, CID#1411635 ("Missing unlock")

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: James Smart <james.smart@broadcom.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 332ba3b5

drivers/scsi/lpfc/lpfc_sli.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -952,7 +952,7 @@ __lpfc_sli_get_els_sglq(struct lpfc_hba phba, struct lpfc_iocbq piocbq)
		start_sglq = sglq;
		while (!found) {
		if (!sglq)
		return NULL;
		break;
		if (ndlp && ndlp->active_rrqs_xri_bitmap &&
		test_bit(sglq->sli4_lxritag,
		ndlp->active_rrqs_xri_bitmap)) {

Admin message