USB: serial: kl5kusb105: remove KLSI device id (d118851a) · Commits · 戴 / test

This driver was apparently never tested with an actual KLSI device. In fact, even the device-id entry which was supposed to allow for this had a typo in it. Tests now reveal that the predicted firmware differences with the PalmConnect adapters are real and that the driver does not support KLSI devices with PID 0x000c, so let's remove the broken entry. Reported-by:

Chris Jakob <chris.jakob@gmail.com> Signed-off-by:

Johan Hovold <johan@kernel.org>

drivers/usb/serial/kl5kusb105.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -67,7 +67,6 @@ static int klsi_105_prepare_write_buffer(struct usb_serial_port *port,
		*/
		static const struct usb_device_id id_table[] = {
		{ USB_DEVICE(PALMCONNECT_VID, PALMCONNECT_PID) },
		{ USB_DEVICE(KLSI_VID, KLSI_KL5KUSB105D_PID) },
		{ } /* Terminating entry */
		};

drivers/usb/serial/kl5kusb105.h

+0 −3

Original line number	Diff line number	Diff line
		@@ -7,9 +7,6 @@
		#define PALMCONNECT_VID 0x0830
		#define PALMCONNECT_PID 0x0080

		#define KLSI_VID 0x05e9
		#define KLSI_KL5KUSB105D_PID 0x00c0

		/* Vendor commands: */

Admin message