Commit d1187ed2 authored by Christoph Lameter's avatar Christoph Lameter Committed by Linus Torvalds
Browse files

vmstat: use our own timer events 



vmstat is currently using the cache reaper to periodically bring the
statistics up to date.  The cache reaper does only exists in SLUB as a way to
provide compatibility with SLAB.  This patch removes the vmstat calls from the
slab allocators and provides its own handling.

The advantage is also that we can use a different frequency for the updates.
Refreshing vm stats is a pretty fast job so we can run this every second and
stagger this by only one tick.  This will lead to some overlap in large
systems.  F.e a system running at 250 HZ with 1024 processors will have 4 vm
updates occurring at once.

However, the vm stats update only accesses per node information.  It is only
necessary to stagger the vm statistics updates per processor in each node.  Vm
counter updates occurring on distant nodes will not cause cacheline
contention.

We could implement an alternate approach that runs the first processor on each
node at the second and then each of the other processor on a node on a
subsequent tick.  That may be useful to keep a large amount of the second free
of timer activity.  Maybe the timer folks will have some feedback on this one?

[jirislaby@gmail.com: add missing break]
Cc: Arjan van de Ven <arjan@linux.intel.com>
Signed-off-by: default avatarChristoph Lameter <clameter@sgi.com>
Signed-off-by: default avatarJiri Slaby <jirislaby@gmail.com>
Cc: Oleg Nesterov <oleg@tv-sign.ru>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 455c017a

include/linux/vmstat.h

+0 −3
Original line number Diff line number Diff line
@@ -212,8 +212,6 @@ extern void dec_zone_state(struct zone *, enum zone_stat_item); 
extern void __dec_zone_state(struct zone *, enum zone_stat_item);



void refresh_cpu_vm_stats(int);

void refresh_vm_stats(void);



#else /* CONFIG_SMP */



/*
@@ -260,7 +258,6 @@ static inline void __dec_zone_page_state(struct page *page, 
#define mod_zone_page_state __mod_zone_page_state



static inline void refresh_cpu_vm_stats(int cpu) { }

static inline void refresh_vm_stats(void) { }

#endif



#endif /* _LINUX_VMSTAT_H */

mm/slab.c

+0 −1
Original line number Diff line number Diff line
@@ -4156,7 +4156,6 @@ next: 
	check_irq_on();

	mutex_unlock(&cache_chain_mutex);

	next_reap_node();

	refresh_cpu_vm_stats(smp_processor_id());

out:

	/* Set up the next iteration */

	schedule_delayed_work(work, round_jiffies_relative(REAPTIMEOUT_CPUC));

mm/slub.c

+0 −1
Original line number Diff line number Diff line
@@ -2580,7 +2580,6 @@ static DEFINE_PER_CPU(struct delayed_work, reap_work); 
static void cache_reap(struct work_struct *unused)

{

	next_reap_node();

	refresh_cpu_vm_stats(smp_processor_id());

	schedule_delayed_work(&__get_cpu_var(reap_work),

				      REAPTIMEOUT_CPUC);

}

mm/vmstat.c

+36 −4
Original line number Diff line number Diff line
@@ -640,6 +640,22 @@ const struct seq_operations vmstat_op = { 
#endif /* CONFIG_PROC_FS */



#ifdef CONFIG_SMP

static DEFINE_PER_CPU(struct delayed_work, vmstat_work);



static void vmstat_update(struct work_struct *w)

{

	refresh_cpu_vm_stats(smp_processor_id());

	schedule_delayed_work(&__get_cpu_var(vmstat_work), HZ);

}



static void __devinit start_cpu_timer(int cpu)

{

	struct delayed_work *vmstat_work = &per_cpu(vmstat_work, cpu);



	INIT_DELAYED_WORK(vmstat_work, vmstat_update);

	schedule_delayed_work_on(cpu, vmstat_work, HZ + cpu);

}



/*

 * Use the cpu notifier to insure that the thresholds are recalculated

 * when necessary.
@@ -648,11 +664,22 @@ static int __cpuinit vmstat_cpuup_callback(struct notifier_block *nfb, 
		unsigned long action,

		void *hcpu)

{

	long cpu = (long)hcpu;



	switch (action) {

	case CPU_UP_PREPARE:

	case CPU_UP_PREPARE_FROZEN:

	case CPU_UP_CANCELED:

	case CPU_UP_CANCELED_FROZEN:

	case CPU_ONLINE:

	case CPU_ONLINE_FROZEN:

		start_cpu_timer(cpu);

		break;

	case CPU_DOWN_PREPARE:

	case CPU_DOWN_PREPARE_FROZEN:

		cancel_rearming_delayed_work(&per_cpu(vmstat_work, cpu));

		per_cpu(vmstat_work, cpu).work.func = NULL;

		break;

	case CPU_DOWN_FAILED:

	case CPU_DOWN_FAILED_FROZEN:

		start_cpu_timer(cpu);

		break;

	case CPU_DEAD:

	case CPU_DEAD_FROZEN:

		refresh_zone_stat_thresholds();
@@ -668,8 +695,13 @@ static struct notifier_block __cpuinitdata vmstat_notifier = 


int __init setup_vmstat(void)

{

	int cpu;



	refresh_zone_stat_thresholds();

	register_cpu_notifier(&vmstat_notifier);



	for_each_online_cpu(cpu)

		start_cpu_timer(cpu);

	return 0;

}

module_init(setup_vmstat)

CRA Git | Maintained and supported by SUSTech CRA and CCSE