Commit d110cf0a authored Jul 12, 2020 by Christophe JAILLET Committed by Herbert Xu Jul 16, 2020

crypto: chelsio - Avoid some code duplication



The error handling path of 'chcr_authenc_setkey()' is the same as this
error handling code.

So just 'goto out' as done everywhere in the function to simplify the code.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

parent e456ef6a

drivers/crypto/chelsio/chcr_algo.c

+1 −3

Original line number	Diff line number	Diff line
		@@ -3598,9 +3598,7 @@ static int chcr_authenc_setkey(struct crypto_aead authenc, const u8 key,
		base_hash = chcr_alloc_shash(max_authsize);
		if (IS_ERR(base_hash)) {
		pr_err("chcr : Base driver cannot be loaded\n");
		aeadctx->enckey_len = 0;
		memzero_explicit(&keys, sizeof(keys));
		return -EINVAL;
		goto out;
		}
		{
		SHASH_DESC_ON_STACK(shash, base_hash);

Admin message