Commit d10689b6 authored Aug 23, 2005 by Paul Jackson Committed by Linus Torvalds Aug 23, 2005

[PATCH] cpu_exclusive sched domains on partial nodes temp fix



This keeps the kernel/cpuset.c routine update_cpu_domains() from
invoking the sched.c routine partition_sched_domains() if the cpuset in
question doesn't fall on node boundaries.

I have boot tested this on an SN2, and with the help of a couple of ad
hoc printk's, determined that it does indeed avoid calling the
partition_sched_domains() routine on partial nodes.

I did not directly verify that this avoids setting up bogus sched
domains or avoids the oops that Hawkes saw.

This patch imposes a silent artificial constraint on which cpusets can
be used to define dynamic sched domains.

This patch should allow proceeding with this new feature in 2.6.13 for
the configurations in which it is useful (node alligned sched domains)
while avoiding trying to setup sched domains in the less useful cases
that can cause the kernel corruption and oops.

Signed-off-by: Paul Jackson <pj@sgi.com>
Acked-by: Ingo Molnar <mingo@elte.hu>
Acked-by: Dinakar Guniguntala <dino@in.ibm.com>
Acked-by: John Hawkes <hawkes@sgi.com>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent ae75784b

kernel/cpuset.c

+17 −0

Original line number	Original line	Diff line number	Diff line
	@@ -635,6 +635,23 @@ static void update_cpu_domains(struct cpuset *cur)
	if (par == NULL \|\| cpus_empty(cur->cpus_allowed))		if (par == NULL \|\| cpus_empty(cur->cpus_allowed))
	return;		return;

			/*
			* Hack to avoid 2.6.13 partial node dynamic sched domain bug.
			* Require the 'cpu_exclusive' cpuset to include all (or none)
			* of the CPUs on each node, or return w/o changing sched domains.
			* Remove this hack when dynamic sched domains fixed.
			*/
			{
			int i, j;

			for_each_cpu_mask(i, cur->cpus_allowed) {
			for_each_cpu_mask(j, node_to_cpumask(cpu_to_node(i))) {
			if (!cpu_isset(j, cur->cpus_allowed))
			return;
			}
			}
			}

	/*		/*
	* Get all cpus from parent's cpus_allowed not part of exclusive		* Get all cpus from parent's cpus_allowed not part of exclusive
	* children		* children

Admin message