Commit d0ef10c9 authored Jun 26, 2017 by John Garry Committed by Martin K. Petersen Jun 26, 2017

scsi: hisi_sas: redefine hisi_sas_phy.phy_type as u32



Element phy_type is a bitmask and it only ever has 2 bits possibly set,
and it is overkill to define as a u64, so redefine as a u32.

This change resolves static code check complaint that "phy->phy_type &=
~PORT_TYPE_SAS;" would unintentionally clear the high 32 bits as well.

Structure hisi_sas_phy is also reordered to ensure packing efficiency.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 6e9017fe

drivers/scsi/hisi_sas/hisi_sas.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -85,11 +85,11 @@ struct hisi_sas_phy {
		struct work_struct phyup_ws;
		u64 port_id; /* from hw */
		u64 dev_sas_addr;
		u64 phy_type;
		u64 frame_rcvd_size;
		u8 frame_rcvd[32];
		u8 phy_attached;
		u8 reserved[3];
		u32 phy_type;
		enum sas_linkrate minimum_linkrate;
		enum sas_linkrate maximum_linkrate;
		};

Admin message