Commit d0dd63a8 authored by Deepa Dinamani's avatar Deepa Dinamani Committed by Thomas Gleixner
Browse files

time: Introduce struct __kernel_itimerspec 



struct itimerspec is not y2038-safe.

Introduce a new struct __kernel_itimerspec based on the kernel internal
y2038-safe struct itimerspec64.

The definition of struct __kernel_itimerspec includes two struct
__kernel_timespec.

Since struct __kernel_timespec has the same representation in native and
compat modes, so does struct __kernel_itimerspec. This helps have a common
entry point for syscalls using struct __kernel_itimerspec.

New y2038-safe syscalls will use this new type. Since most of the new
syscalls are just an update to the native syscalls with the type update,
place the new definition under CONFIG_64BIT_TIME. This helps architectures
that do not support the above config to keep using the old definition of
struct itimerspec.

Also change the get/put_itimerspec64 to use struct__kernel_itimerspec.
This will help 32 bit architectures to use the new syscalls when
architectures select CONFIG_64BIT_TIME.

Signed-off-by: default avatarDeepa Dinamani <deepa.kernel@gmail.com>
Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
Cc: arnd@arndb.de
Cc: viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org
Cc: linux-api@vger.kernel.org
Cc: y2038@lists.linaro.org
Link: https://lkml.kernel.org/r/20180617051144.29756-2-deepa.kernel@gmail.com
parent dc1b7b6c

include/linux/time.h

+2 −2
Original line number Diff line number Diff line
@@ -14,9 +14,9 @@ int get_timespec64(struct timespec64 *ts, 
int put_timespec64(const struct timespec64 *ts,

		struct __kernel_timespec __user *uts);

int get_itimerspec64(struct itimerspec64 *it,

			const struct itimerspec __user *uit);

			const struct __kernel_itimerspec __user *uit);

int put_itimerspec64(const struct itimerspec64 *it,

			struct itimerspec __user *uit);

			struct __kernel_itimerspec __user *uit);



extern time64_t mktime64(const unsigned int year, const unsigned int mon,

			const unsigned int day, const unsigned int hour,

include/linux/time64.h

+1 −0
Original line number Diff line number Diff line
@@ -12,6 +12,7 @@ typedef __u64 timeu64_t; 
 */

#ifndef CONFIG_64BIT_TIME

#define __kernel_timespec timespec

#define __kernel_itimerspec itimerspec

#endif



#include <uapi/linux/time.h>

include/uapi/linux/time.h

+7 −0
Original line number Diff line number Diff line
@@ -49,6 +49,13 @@ struct __kernel_timespec { 
};

#endif



#ifndef __kernel_itimerspec

struct __kernel_itimerspec {

	struct __kernel_timespec it_interval;    /* timer period */

	struct __kernel_timespec it_value;       /* timer expiration */

};

#endif



/*

 * legacy timeval structure, only embedded in structures that

 * traditionally used 'timeval' to pass time intervals (not absolute

kernel/time/time.c

+2 −2
Original line number Diff line number Diff line
@@ -927,7 +927,7 @@ int compat_put_timespec64(const struct timespec64 *ts, void __user *uts) 
EXPORT_SYMBOL_GPL(compat_put_timespec64);



int get_itimerspec64(struct itimerspec64 *it,

			const struct itimerspec __user *uit)

			const struct __kernel_itimerspec __user *uit)

{

	int ret;
@@ -942,7 +942,7 @@ int get_itimerspec64(struct itimerspec64 *it, 
EXPORT_SYMBOL_GPL(get_itimerspec64);



int put_itimerspec64(const struct itimerspec64 *it,

			struct itimerspec __user *uit)

			struct __kernel_itimerspec __user *uit)

{

	int ret;

CRA Git | Maintained and supported by SUSTech CRA and CCSE