Commit d0d88b5c authored Jun 28, 2019 by Andrew Jeffery Committed by Linus Walleij Jul 03, 2019

pinctrl: aspeed: Clarify comment about strapping W1C



Writes of 1 to SCU7C clear set bits in SCU70, the hardware strapping
register. The information was correct if you squinted while reading, but
hopefully switching the order of the registers as listed conveys it
better.

Cc: Johnny Huang <johnny_huang@aspeedtech.com>
Signed-off-by: Andrew Jeffery <andrew@aj.id.au>
Acked-by: Joel Stanley <joel@jms.id.au>
Link: https://lore.kernel.org/r/20190628023838.15426-7-andrew@aj.id.au


Signed-off-by: Linus Walleij <linus.walleij@linaro.org>

parent 0290eba9

drivers/pinctrl/aspeed/pinctrl-aspeed.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -213,7 +213,7 @@ static int aspeed_sig_expr_set(const struct aspeed_sig_expr *expr,
		if (desc->ip == ASPEED_IP_SCU && desc->reg == HW_STRAP2)
		continue;

		/* On AST2500, Set bits in SCU7C are cleared from SCU70 */
		/* On AST2500, Set bits in SCU70 are cleared from SCU7C */
		if (desc->ip == ASPEED_IP_SCU && desc->reg == HW_STRAP1) {
		unsigned int rev_id;

Admin message