Commit d0cc439b authored Jun 25, 2015 by Arnaldo Carvalho de Melo

perf trace: Validate syscall list passed via -e argument



The 'trace' tool was accepting any names passed and just looking if
syscalls returned via the raw_syscalls:* tracepoints were in that list,
leading to it accepting perf events and then never finding any, as those
are not valid syscall names, confusing users.

Fix it by checking each entry in the list using audit_name_to_syscall,
telling the user which entries are invalid and suggesting where to look
for valid syscall names.

E.g:

  [root@zoo ~]# trace -e open,foo,bar,close,baz
  Error: Invalid syscall bar, baz, foo
  Hint:	 try 'perf list syscalls:sys_enter_*'
  Hint:	 and: 'man syscalls'
  [root@zoo ~]#

Reported-by: Flavio Leitner <fbl@redhat.com>
Cc: Adrian Hunter <adrian.hunter@intel.com>
Cc: Borislav Petkov <bp@suse.de>
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Cc: Namhyung Kim <namhyung@kernel.org>
Link: http://lkml.kernel.org/n/tip-4g1i3m1z6fzsrznn2umi02wa@git.kernel.org


Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>

parent 6eedf416

tools/perf/builtin-trace.c

+32 −0

Original line number	Diff line number	Diff line
		@@ -1617,6 +1617,34 @@ static int trace__read_syscall_info(struct trace *trace, int id)
		return syscall__set_arg_fmts(sc);
		}

		static int trace__validate_ev_qualifier(struct trace *trace)
		{
		int err = 0;
		struct str_node *pos;

		strlist__for_each(pos, trace->ev_qualifier) {
		const char *sc = pos->s;

		if (audit_name_to_syscall(sc, trace->audit.machine) < 0) {
		if (err == 0) {
		fputs("Error:\tInvalid syscall ", trace->output);
		err = -EINVAL;
		} else {
		fputs(", ", trace->output);
		}

		fputs(sc, trace->output);
		}
		}

		if (err < 0) {
		fputs("\nHint:\ttry 'perf list syscalls:sys_enter_*'"
		"\nHint:\tand: 'man syscalls'\n", trace->output);
		}

		return err;
		}

		/*
		* args is to be interpreted as a series of longs but we need to handle
		* 8-byte unaligned accesses. args points to raw_data within the event
		@@ -2862,6 +2890,10 @@ int cmd_trace(int argc, const char *argv, const char prefix __maybe_unused)
		err = -ENOMEM;
		goto out_close;
		}

		err = trace__validate_ev_qualifier(&trace);
		if (err)
		goto out_close;
		}

		err = target__validate(&trace.opts.target);

Admin message