Commit d0ca2c35 authored Mar 23, 2020 by Zhu Yanjun Committed by Jason Gunthorpe Mar 26, 2020

RDMA/rxe: Set sys_image_guid to be aligned with HW IB devices

The RXE driver doesn't set sys_image_guid and user space applications see
zeros. This causes to pyverbs tests to fail with the following traceback,
because the IBTA spec requires to have valid sys_image_guid.

 Traceback (most recent call last):
   File "./tests/test_device.py", line 51, in test_query_device
     self.verify_device_attr(attr)
   File "./tests/test_device.py", line 74, in verify_device_attr
     assert attr.sys_image_guid != 0

In order to fix it, set sys_image_guid to be equal to node_guid.

Before:
 5: rxe0: ... node_guid 5054:00ff:feaa:5363 sys_image_guid
 0000:0000:0000:0000

After:
 5: rxe0: ... node_guid 5054:00ff:feaa:5363 sys_image_guid
 5054:00ff:feaa:5363

Fixes: 8700e3e7 ("Soft RoCE driver")
Link: https://lore.kernel.org/r/20200323112800.1444784-1-leon@kernel.org


Signed-off-by: Zhu Yanjun <yanjunz@mellanox.com>
Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>

parent 23ab5261

drivers/infiniband/sw/rxe/rxe.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -103,6 +103,8 @@ static void rxe_init_device_param(struct rxe_dev *rxe)
		rxe->attr.max_fast_reg_page_list_len = RXE_MAX_FMR_PAGE_LIST_LEN;
		rxe->attr.max_pkeys = RXE_MAX_PKEYS;
		rxe->attr.local_ca_ack_delay = RXE_LOCAL_CA_ACK_DELAY;
		addrconf_addr_eui48((unsigned char *)&rxe->attr.sys_image_guid,
		rxe->ndev->dev_addr);

		rxe->max_ucontext = RXE_MAX_UCONTEXT;
		}

Admin message