Commit d0c44718 authored by Steven Rostedt's avatar Steven Rostedt Committed by Eric Van Hensbergen
Browse files

9p: fix flags length in net 



Some files in the net/9p directory uses "int" for flags. This can
cause hard to find bugs on some architectures. This patch converts the
flags to use "long" instead.

This bug was discovered by doing an allyesconfig make on the -rt kernel
where checks are done to ensure all flags are of size sizeof(long).

Signed-off-by: default avatarSteven Rostedt <srostedt@redhat.com>
Acked-by: default avatarEric Van Hensbergen <ericvh@gmail.com>
parent 728fc4ef

net/9p/trans_virtio.c

+1 −1
Original line number Diff line number Diff line
@@ -201,7 +201,7 @@ static void p9_virtio_close(struct p9_trans *trans) 
{

	struct virtio_chan *chan = trans->priv;

	int count;

	unsigned int flags;

	unsigned long flags;



	spin_lock_irqsave(&chan->lock, flags);

	p9_idpool_destroy(chan->tagpool);

net/9p/util.c

+2 −2
Original line number Diff line number Diff line
@@ -88,7 +88,7 @@ int p9_idpool_get(struct p9_idpool *p) 
{

	int i = 0;

	int error;

	unsigned int flags;

	unsigned long flags;



retry:

	if (idr_pre_get(&p->pool, GFP_KERNEL) == 0)
@@ -120,7 +120,7 @@ EXPORT_SYMBOL(p9_idpool_get); 


void p9_idpool_put(int id, struct p9_idpool *p)

{

	unsigned int flags;

	unsigned long flags;

	spin_lock_irqsave(&p->lock, flags);

	idr_remove(&p->pool, id);

	spin_unlock_irqrestore(&p->lock, flags);

CRA Git | Maintained and supported by SUSTech CRA and CCSE