Commit d097c024 authored Sep 09, 2015 by Frederic Weisbecker Committed by Linus Torvalds Sep 10, 2015

kmod: remove unecessary explicit wide CPU affinity setting



Khelper is affine to all CPUs.  Now since it creates the
call_usermodehelper_exec_[a]sync() kernel threads, those inherit the wide
affinity.

As such explicitly forcing a wide affinity from those kernel threads
is like a no-op.

Just remove it. It's needless and it breaks CPU isolation users who
rely on workqueue affinity tuning.

Signed-off-by: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Rik van Riel <riel@redhat.com>
Reviewed-by: Oleg Nesterov <oleg@redhat.com>
Cc: Christoph Lameter <cl@linux.com>
Cc: Tejun Heo <tj@kernel.org>
Cc: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent b6b50a81

kernel/kmod.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -224,9 +224,6 @@ static int call_usermodehelper_exec_async(void *data)
		flush_signal_handlers(current, 1);
		spin_unlock_irq(&current->sighand->siglock);

		/* We can run anywhere, unlike our parent keventd(). */
		set_cpus_allowed_ptr(current, cpu_all_mask);

		/*
		* Our parent is keventd, which runs with elevated scheduling priority.
		* Avoid propagating that into the userspace child.

Admin message