Commit d0959b08 authored by Steve French's avatar Steve French
Browse files

smb3: remove noisy debug message and minor cleanup 



Message was intended only for developer temporary build
In addition cleanup two minor warnings noticed by Coverity
and a trivial change to workaround a sparse warning

Signed-off-by: default avatarSteve French <stfrench@microsoft.com>
Reviewed-by: default avatarPavel Shilovsky <pshilov@microsoft.com>
parent 30573a82

fs/cifs/cifsglob.h

+1 −1
Original line number Diff line number Diff line
@@ -1210,7 +1210,7 @@ struct cifs_search_info { 
	bool smallBuf:1; /* so we know which buf_release function to call */

};



#define ACL_NO_MODE	-1

#define ACL_NO_MODE	((umode_t)(-1))

struct cifs_open_parms {

	struct cifs_tcon *tcon;

	struct cifs_sb_info *cifs_sb;

fs/cifs/connect.c

+1 −1
Original line number Diff line number Diff line
@@ -4445,7 +4445,7 @@ static int setup_dfs_tgt_conn(const char *path, 
	int rc;

	struct dfs_info3_param ref = {0};

	char *mdata = NULL, *fake_devname = NULL;

	struct smb_vol fake_vol = {0};

	struct smb_vol fake_vol = {NULL};



	cifs_dbg(FYI, "%s: dfs path: %s\n", __func__, path);

fs/cifs/smb2pdu.c

+4 −7
Original line number Diff line number Diff line
@@ -751,8 +751,8 @@ add_posix_context(struct kvec *iov, unsigned int *num_iovec, umode_t mode) 
	unsigned int num = *num_iovec;



	iov[num].iov_base = create_posix_buf(mode);

	if (mode == -1)

		cifs_dbg(VFS, "illegal mode\n"); /* BB REMOVEME */

	if (mode == ACL_NO_MODE)

		cifs_dbg(FYI, "illegal mode\n");

	if (iov[num].iov_base == NULL)

		return -ENOMEM;

	iov[num].iov_len = sizeof(struct create_posix);
@@ -2521,11 +2521,8 @@ SMB2_open_init(struct cifs_tcon *tcon, struct smb_rqst *rqst, __u8 *oplock, 
			return rc;

	}



	/* TODO: add handling for the mode on create */

	if (oparms->disposition == FILE_CREATE)

		cifs_dbg(VFS, "mode is 0x%x\n", oparms->mode); /* BB REMOVEME */



	if ((oparms->disposition == FILE_CREATE) && (oparms->mode != -1)) {

	if ((oparms->disposition == FILE_CREATE) &&

	    (oparms->mode != ACL_NO_MODE)) {

		if (n_iov > 2) {

			struct create_context *ccontext =

			    (struct create_context *)iov[n_iov-1].iov_base;

CRA Git | Maintained and supported by SUSTech CRA and CCSE