Commit d0863792 authored Dec 23, 2018 by Julia Lawall Committed by David S. Miller Dec 24, 2018

mlxsw: spectrum: drop useless LIST_HEAD

Drop LIST_HEAD where the variable it declares is never used.

The uses were removed in 244cd96a ("net_sched: remove
list_head from tc_action"), but not the declaration.

The semantic patch that fixes this problem is as follows:
(http://coccinelle.lip6.fr/

)

// <smpl>
@@
identifier x;
@@
- LIST_HEAD(x);
  ... when != x
// </smpl>

Fixes: 244cd96a ("net_sched: remove list_head from tc_action")
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2534f14a

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -1347,7 +1347,6 @@ static int mlxsw_sp_port_add_cls_matchall(struct mlxsw_sp_port *mlxsw_sp_port,
		struct mlxsw_sp_port_mall_tc_entry *mall_tc_entry;
		__be16 protocol = f->common.protocol;
		const struct tc_action *a;
		LIST_HEAD(actions);
		int err;

		if (!tcf_exts_has_one_action(f->exts)) {

Admin message