Commit d06d60d5 authored Nov 16, 2020 by Manish Narani Committed by Ulf Hansson Nov 17, 2020

mmc: sdhci-of-arasan: Issue DLL reset explicitly



In the current implementation DLL reset will be issued for
each ITAP and OTAP setting inside ATF, this is creating issues
in some scenarios and this sequence is not inline with the TRM.
To fix the issue, DLL reset should be removed from the ATF and
host driver will request it explicitly.
This patch update host driver to explicitly request for DLL reset
before ITAP (assert DLL) and after OTAP (release DLL) settings.

Fixes: a5c8b2ae ("mmc: sdhci-of-arasan: Add support for ZynqMP Platform Tap Delays Setup")
Signed-off-by: Sai Krishna Potthuri <lakshmi.sai.krishna.potthuri@xilinx.com>
Signed-off-by: Manish Narani <manish.narani@xilinx.com>
Acked-by: Michal Simek <michal.simek@xilinx.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/1605515565-117562-4-git-send-email-manish.narani@xilinx.com


Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent d338c6d0

drivers/mmc/host/sdhci-of-arasan.c

+6 −0

Original line number	Diff line number	Diff line
		@@ -635,6 +635,9 @@ static int sdhci_zynqmp_sdcardclk_set_phase(struct clk_hw *hw, int degrees)
		if (ret)
		pr_err("Error setting Output Tap Delay\n");

		/* Release DLL Reset */
		zynqmp_pm_sd_dll_reset(node_id, PM_DLL_RESET_RELEASE);

		return ret;
		}

		@@ -669,6 +672,9 @@ static int sdhci_zynqmp_sampleclk_set_phase(struct clk_hw *hw, int degrees)
		if (host->version < SDHCI_SPEC_300)
		return 0;

		/* Assert DLL Reset */
		zynqmp_pm_sd_dll_reset(node_id, PM_DLL_RESET_ASSERT);

		switch (host->timing) {
		case MMC_TIMING_MMC_HS:
		case MMC_TIMING_SD_HS:

Admin message